Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move src/test/run-fail tests to UI #274

Closed
JohnTitor opened this issue Apr 16, 2020 · 6 comments
Closed

Move src/test/run-fail tests to UI #274

JohnTitor opened this issue Apr 16, 2020 · 6 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted

Comments

@JohnTitor
Copy link
Member

TL;DR

Move src/test/run-fail tests to UI to unify the test structure.

Links and Details

Questions

Mentors or Reviewers

@nikomatsakis
@JohnTitor JohnTitor added the major-change A proposal to make a major change to rustc label Apr 16, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 16, 2020
@JohnTitor JohnTitor mentioned this issue Apr 16, 2020
Merged
@petrochenkov
Copy link

I support the change, multiple other test suites were already successfully migrated to UI, including run-pass.

If some tests cannot be migrated right now due to heavily platform-dependent output or similar reasons, they can stay in run-fail for now and be dealt with later.

It's more convenient to fix rust-lang/rust#65865 after the run-fail -> ui change, but soon enough to avoid new uses of error-pattern for runtime output.

@Mark-Simulacrum
Copy link
Member

(I suspect @petrochenkov may have forgotten to, but regardless I'm willing to do it: @rustbot seconded).

@Mark-Simulacrum
Copy link
Member

Gah, bad bot, @rustbot seconded.

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Apr 16, 2020
@petrochenkov
Copy link

petrochenkov commented Apr 16, 2020 •
edited
Loading

I didn't even know the automation was already implemented.
Is it documented anywhere? EDIT: https://github.com/rust-lang/triagebot/wiki/Major-changes

@spastorino
Copy link
Member

Added to our compiler team meeting agenda, removing to-announce label.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Apr 23, 2020
@nikomatsakis nikomatsakis added the major-change-accepted A major change proposal that was accepted label May 7, 2020
@nikomatsakis
Copy link
Contributor

Huzzah! This proposal has been accepted.

@spastorino spastorino removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@spastorino @nikomatsakis @Mark-Simulacrum @petrochenkov @JohnTitor @rustbot