Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Migrate run-fail tests in src/test/ui from error-pattern to check-run-results #65865

Open
3 tasks
tmiasko opened this issue Oct 27, 2019 · 1 comment
Open
3 tasks

Cleanup: Migrate run-fail tests in src/test/ui from error-pattern to check-run-results #65865

tmiasko opened this issue Oct 27, 2019 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@tmiasko
Copy link
Contributor

tmiasko commented Oct 27, 2019

As tests are moved from src/test/run-fail to src/test/ui #65440 the meaning
of // error-pattern in ui tests becomes overloaded , since tests in
src/test/run-fail match error patterns to executable output while
src/test/ui tests match them to compiler output.

The changes in #65759 enable such overloaded use: if test is expected to
compile successfully and will be run, the patterns are matched to executable
output, otherwise patterns are matched to the compiler output.

@petrochenkov suggested that it might be preferable to migrate those test to use check-run-result instead.

  1. Decide if check-run-result is preferable over error-pattern for run-fail tests in ui.
  2. Migrate run fail tests to use check-run-result.
  3. Remove support for overloaded meaning of error-pattern.
@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 27, 2019
@petrochenkov petrochenkov mentioned this issue Dec 1, 2019
Closed
@petrochenkov petrochenkov mentioned this issue Dec 14, 2019
Merged
@JohnTitor JohnTitor added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 16, 2020
@JohnTitor JohnTitor mentioned this issue Apr 16, 2020
Merged
@petrochenkov
Copy link
Contributor

Another option is to do "check-run-results" automatically for all run-* tests and create the .run.stderr / .run.stdout files only if the output is not empty.

@JohnTitor JohnTitor mentioned this issue Apr 16, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this issue May 9, 2020
@RalfJung
Rollup merge of rust-lang#71185 - JohnTitor:run-fail, r=petrochenkov
1704dca 
Move tests from `test/run-fail` to UI

Fixes rust-lang#65440
cc rust-lang#65865 rust-lang#65506
r? @nikomatsakis
@RalfJung RalfJung mentioned this issue May 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @petrochenkov @JohnTitor @tmiasko