Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type folding to take self by value #371

Closed
1 of 3 tasks
lcnr opened this issue Oct 17, 2020 · 2 comments
Closed
1 of 3 tasks

Change type folding to take self by value #371

lcnr opened this issue Oct 17, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@lcnr
Copy link
Contributor

lcnr commented Oct 17, 2020

Proposal

Try changing both fold_with and super_fold_with to take self by value instead of by reference.
This removes a lot of unnecessary borrows and clones. It will have an influence on perf, which if negative will
result in this MCP being discarded.

rust-lang/rust#78027 implements the same change for Lift.

Mentors or Reviewers

🤷

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@lcnr lcnr added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Oct 17, 2020
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Oct 17, 2020
@nikomatsakis
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 18, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Oct 22, 2020
@lcnr lcnr mentioned this issue Oct 24, 2020
Merged
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 28, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Oct 28, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Oct 29, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 17, 2020
@bors
Auto merge of rust-lang#78313 - lcnr:somebody-fold-me, r=nikomatsakis
9b2b02a 
TypeFoldable: take self by value

Implements rust-lang/compiler-team#371 which is currently still in FCP.

r? `@nikomatsakis`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @nikomatsakis @lcnr @rustbot