Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeVisitor: use ops::ControlFlow instead of bool #374

Closed
1 of 3 tasks
lcnr opened this issue Oct 20, 2020 · 2 comments
Closed
1 of 3 tasks

TypeVisitor: use ops::ControlFlow instead of bool #374

lcnr opened this issue Oct 20, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@lcnr
Copy link
Contributor

lcnr commented Oct 20, 2020 •
edited by scottmcm
Loading

Proposal

change the visit methods of TypeFoldable and TypeVisitor to use std::ops::ControlFlow<()> instead of bool. In the future we may change the used type to std::ops::ControlFlow<Self::BreakTy> but this is not part of this MCP for now. [ed: updated the type signatures post rust-lang/rust#76614]

This makes it more intuitive and means that we can stop adding comments like false // keep visiting, for example in https://github.com/rust-lang/rust/blob/9832374f6e378971e1a933362cf9781b121bb845/compiler/rustc_trait_selection/src/opaque_types.rs#L696.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@lcnr lcnr added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Oct 20, 2020
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Oct 20, 2020
@jonas-schievink
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 20, 2020
@scottmcm scottmcm mentioned this issue Oct 21, 2020
Closed
9 tasks
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Oct 21, 2020
Merged
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Oct 22, 2020
@LeSeulArtichaut LeSeulArtichaut added the major-change-accepted A major change proposal that was accepted label Oct 30, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Oct 30, 2020
@LeSeulArtichaut LeSeulArtichaut removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 30, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 30, 2020
@bors
Auto merge of rust-lang#78182 - LeSeulArtichaut:ty-visitor-contolflow…
0d033de 
…, r=lcnr,oli-obk

TypeVisitor: use `std::ops::ControlFlow` instead of `bool`

Implements MCP rust-lang/compiler-team#374.

Blocked on FCP in rust-lang/compiler-team#374.
r? `@lcnr` cc `@jonas-schievink`
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Nov 5, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Nov 5, 2020
Closed
3 tasks
@QuineDot QuineDot mentioned this issue Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spastorino @jonas-schievink @lcnr @LeSeulArtichaut @rustbot