Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a scheme to register functions from other crates with TyCtxt #395

Closed
1 of 3 tasks
oli-obk opened this issue Dec 30, 2020 · 2 comments
Closed
1 of 3 tasks

Add a scheme to register functions from other crates with TyCtxt #395

oli-obk opened this issue Dec 30, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Dec 30, 2020

Proposal

Similarly to queries, we should also have a scheme to register functions in a very lightweight manner. This would allow us to have implementations in crates that come after rustc_middle while being able to call said functions from any crate that has access to TyCtxt. While one could use a query for that in many cases, as already mentioned queries are expensive, but additionally, not everything can be in a query argument. Query arguments must be StableHash, which can be problematic.

More concretely, with such a scheme we would have an easy way to fix rust-lang/rust#77650 and rust-lang/rust#77708 (some discussion in https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/incremental.20const_evaluatable_checked.20bug/near/221163894)

Mentors or Reviewers

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@oli-obk oli-obk added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Dec 30, 2020
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Dec 30, 2020
@lcnr
Copy link
Contributor

lcnr commented Dec 30, 2020

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Dec 30, 2020
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 31, 2020
@apiraino apiraino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jan 14, 2021
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 14, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 14, 2021
@eopb eopb mentioned this issue Feb 3, 2021
Closed
@lcnr lcnr mentioned this issue Sep 21, 2023
Closed
3 tasks
@oli-obk oli-obk mentioned this issue Sep 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 23, 2023
@bors
Auto merge of rust-lang#116052 - oli-obk:ceci_nest_pas_une_query, r=W…
bf98263 
…affleLapkin

Add a way to decouple the implementation and the declaration of a TyCtxt method.

properly addresses rust-lang#115819

accepted MCP: rust-lang/compiler-team#395
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Sep 24, 2023
@bors
Auto merge of #116052 - oli-obk:ceci_nest_pas_une_query, r=WaffleLapkin
212dae1 
Add a way to decouple the implementation and the declaration of a TyCtxt method.

properly addresses rust-lang/rust#115819

accepted MCP: rust-lang/compiler-team#395
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Sep 25, 2023
@bors
Auto merge of #116052 - oli-obk:ceci_nest_pas_une_query, r=WaffleLapkin
3da69c7 
Add a way to decouple the implementation and the declaration of a TyCtxt method.

properly addresses rust-lang/rust#115819

accepted MCP: rust-lang/compiler-team#395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @apiraino @lcnr @rustbot