Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MIPS to tier 3 #648

Closed
2 of 3 tasks
workingjubilee opened this issue Jul 3, 2023 · 10 comments
Closed
2 of 3 tasks

Drop MIPS to tier 3 #648

workingjubilee opened this issue Jul 3, 2023 · 10 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Jul 3, 2023

Proposal

The target tier policy exists to guarantee targets have a minimum of support and don't cause problems in our CI. The existing tier 2 MIPS targets are causing problems in our CI. Specifically, cross builds from x86-64 hosts to build toolchains suitable for deployment on these hosts:

target std notes
mips-unknown-linux-gnu MIPS Linux (kernel 4.4, glibc 2.23)
mips64-unknown-linux-gnuabi64 MIPS64 Linux, n64 ABI (kernel 4.4, glibc 2.23)
mips64el-unknown-linux-gnuabi64 MIPS64 (LE) Linux, n64 ABI (kernel 4.4, glibc 2.23)
mipsel-unknown-linux-gnu MIPS (LE) Linux (kernel 4.4, glibc 2.23)

Judging by issue rust-lang/rust#113065 this appears to be caused by problems that emerge during isel in LLVM. No one has emerged with an emergency patch to our LLVM fork which resolves the build for these targets. We have opened llvm/llvm-project#63608 upstream but it has yet to receive an acknowledgement that anyone is working on it. Certainly I do not expect anyone to suddenly wave their magic wand and simply banish these problems, but with no efforts to improve maintenance for them coming forward except for the mips{32,64}r6 targets, which are actually different ISAs due to backwards incompatibility, it is apparent this is a clear violation of both the spirit1234 and letter567 of the target tier policy. I recommend we immediately drop all of these problematic targets to tier 3 per the target tier policy89.

I have left ambiguous the fate of the following tier 2 targets without host tools. I have not observed them causing a problem yet, but it is apparent to me they are not actually receiving tier 2 maintenance, either. The lack of problems may be more of a feature of the GNU targets causing problems first, or it may be a feature of them exercising less of the compiler due to only building the stdlib's binary artifacts and whatever support necessary.

target std notes
mips-unknown-linux-musl MIPS Linux with MUSL
mips64-unknown-linux-muslabi64 MIPS64 Linux, n64 ABI, MUSL
mips64el-unknown-linux-muslabi64 MIPS64 (LE) Linux, n64 ABI, MUSL
mipsel-unknown-linux-musl MIPS (LE) Linux with MUSL

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Footnotes

    • Building host tools for the target must not take substantially longer than building host tools for other targets, and should not substantially raise the maintenance burden of the CI infrastructure.
    • Building the target in CI must not take substantially longer than the current slowest target in CI, and should not substantially raise the maintenance burden of the CI infrastructure. This requirement is subjective, to be evaluated by the infrastructure team, and will take the community importance of the target into account.
    • Tier 2 targets must not impose burden on the authors of pull requests, or other developers in the community, to ensure that tests pass for the target.
    • Providing host tools does not exempt a target from requirements to support cross-compilation if at all possible.
    • The host tools must build and run reliably in CI (for all components that Rust's CI considers mandatory), though they may or may not pass tests.
    • Tier 2 targets should, if at all possible, support cross-compiling. Tier 2 targets should not require using the target as the host for builds, even if the target supports host tools.
    • The target must build reliably in CI, for all components that Rust's CI considers mandatory.
    • A tier 2 target may be demoted or removed if it no longer meets these requirements. Any proposal for demotion or removal will be CCed to the target maintainers, and will be communicated widely to the Rust community before being dropped from a stable release.
    • In some circumstances, especially if the target maintainers do not respond in a timely fashion, Rust teams may land pull requests that temporarily disable some targets in the nightly compiler, in order to implement a feature not yet supported by those targets.
@workingjubilee workingjubilee added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jul 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 3, 2023
@compiler-errors
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 3, 2023
@Noratrieb
Copy link
Member

It's important it explicitly add that if someone steps up, fixes these issues and volunteers to be a target maintainer, we can promote them again.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 4, 2023
Remove `mips*-unknown-linux-gnu*` builders

Pursuant to the current consensus in rust-lang/compiler-team#648
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 6, 2023
Amanieu added a commit to Amanieu/rustc-builtins that referenced this issue Jul 6, 2023
@workingjubilee
Copy link
Member Author

While I left it ambiguous at first, I should note the conversation on Zulip inclined towards applying the same judgement to all of the "preexisting" tier 2 MIPS targets, one way or another. Also, while not necessarily immediately affecting this decision, we should probably insist that targets have support from active maintainers for their codegen backend as well, especially before promoting them to higher tiers, lest we have other cases like this. This apparently is currently not true for MIPS and its LLVM backend.

Amanieu added a commit to Amanieu/stdarch that referenced this issue Jul 29, 2023
These targets have been removed from rustup, see rust-lang/compiler-team#648.
@compiler-errors compiler-errors added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 29, 2023
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 29, 2023
@compiler-errors
Copy link
Member

This MCP is accepted 🎉

Amanieu added a commit to rust-lang/stdarch that referenced this issue Jul 29, 2023
These targets have been removed from rustup, see rust-lang/compiler-team#648.
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 4, 2023
hawkw added a commit to tokio-rs/tokio that referenced this issue Aug 25, 2023
Currently, Tokio runs cross-compilation checks for the
`mips-unknown-linux-gnu` and `mipsel-unknown-linux-musl` target triples.
However, Rust has recently demoted these targets from Tier 2 support to
Tier 3 (see rust-lang/compiler-team#648). Therefore, MIPS toolchains may
not always be available, even in stable releases. This is currently
[breaking our CI builds][1], as Rust 1.72.0 does not contain a standard
library for `mips-unknown-linux-gnu`.

This branch removes these builds from the cross-compilation check's
build matrix. Tokio may still build successfully for MIPS targets, but
we can't easily guarantee support when the stable Rust release train may
or may not be able to build for MIPS targets.

[1]: https://github.com/tokio-rs/tokio/actions/runs/5970263562/job/16197657405?pr=5947#step:3:80
rusty-snake pushed a commit to rusty-snake/libseccomp-rs that referenced this issue Dec 2, 2023
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
rusty-snake pushed a commit to rusty-snake/libseccomp-rs that referenced this issue Dec 2, 2023
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
ManaSugi added a commit to libseccomp-rs/libseccomp-rs that referenced this issue Jan 22, 2024
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
rusty-snake pushed a commit to rusty-snake/libseccomp-rs that referenced this issue Jan 26, 2024
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
rusty-snake pushed a commit to rusty-snake/libseccomp-rs that referenced this issue Jan 27, 2024
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
zonyitoo added a commit to shadowsocks/shadowsocks-rust that referenced this issue Feb 5, 2024
ManaSugi added a commit to libseccomp-rs/libseccomp-rs that referenced this issue Feb 9, 2024
`mips-unknown-linux-gnu` and `mips64-unknown-linux-gnuabi64` have been
dropped to Tier 3 since rust 1.72 by rust-lang/compiler-team#648.
Hence, they are no longer available even in the nightly channel.

Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

7 participants