Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --print=lint-levels to retrieve lints levels #833

Open
1 of 3 tasks
Urgau opened this issue Jan 29, 2025 · 2 comments
Open
1 of 3 tasks

Add --print=lint-levels to retrieve lints levels #833

Urgau opened this issue Jan 29, 2025 · 2 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Urgau
Copy link
Member

Urgau commented Jan 29, 2025

Proposal

Add a new unstable --print variant lint-levels (--print=lint-levels -Zunstable-options) that would print out all the lints and their associated levels (allow, warn, deny, forbid) based on the regular Rust rules at crate root, that is:

  • command line args (-W, -A, ...)
  • crate root attributes (#![allow], #![warn], ...)
  • the special warnings lint group
  • the default lint level

The output format would be LINT_NAME=LINT_LEVEL, e.g.:

unknown_lint=warn
arithmetic_overflow=deny

Motivation

Exposing more stuff for external tools. 😄

In particular, exposing the actual lint level for lints could help external tools (like Cargo) extend some built-ins lints, e.g. unknown_lints for Cargo [lints] table1, which would not need to try to compute the lint level, which require knowing the default, interpreting rustc args (and dealing with RUSTFLAGS), ... all of which are non-trivial.

Delegating all that work to the source of truth (rustc), makes it nearly "trivial" for those tools to know the lint level and re-use it.

Mentors or Reviewers

My-self for the work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Footnotes

  1. Cargo has not committed to using this new flag, it should be kept as an example, but it's still a good motivation to try out the flag

@Urgau Urgau added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jan 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2025

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rfcbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rfcbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 29, 2025
@epage
Copy link

epage commented Jan 29, 2025

In particular, exposing the actual lint level for lints could help external tools (like Cargo) extend some built-ins lints, e.g. unknown_lints for Cargo [lints] table, which would not need to try to compute the lint level, which require knowing the default, interpreting rustc args (and dealing with RUSTFLAGS), ... all of which are non-trivial.

Delegating all that work to the source of truth (rustc), makes it nearly "trivial" for those tools to know the lint level and re-use it.

Note that we've not committed to this being how we want to handle lints within Cargo.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants