Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of ember-keyboard #1491

Merged
merged 1 commit into from
Sep 16, 2018

Conversation

ballpointcarrot
Copy link
Contributor

Addresses #1473. New
version of ember-keyboard fixes the issue around keycode vs. key,
allowing hotkey search for non-qwerty keyboards.

Addresses rust-lang#1473. New
version of ember-keyboard fixes the issue around keycode vs. key,
allowing hotkey search for non-qwerty keyboards.
@carols10cents
Copy link
Member

Awesome!! Tested and it works for this dvorak user!! Thank you :)

bors: r+

bors-voyager bot added a commit that referenced this pull request Sep 16, 2018
1491: Update version of ember-keyboard r=carols10cents a=ballpointcarrot

Addresses #1473. New
version of ember-keyboard fixes the issue around keycode vs. key,
allowing hotkey search for non-qwerty keyboards.

Co-authored-by: Christopher Kruse <ckruse@ballpointcarrot.net>
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Sep 16, 2018

Build succeeded

@bors-voyager bors-voyager bot merged commit b8ec483 into rust-lang:master Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants