Switch to conduit-hyper in place of civet
#1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing an issue with this in staging, this isn't ready to merge yet. |
`conduit-hyper` now handles normalizing paths, such that `//api/v1` becomes `/api/v1` and doesn't break our router.
jtgeibel
force-pushed
the
conduit-hyper-round2
branch
from
dfb6e98
to
6c947e3
Compare
|
Okay, I pushed a new version of Here is a crate I published on staging using this PR: https://jtgeibel-staging-crates-io.herokuapp.com/crates/hello-world |
|
Holding off on merging for now so I can deploy this by itself and be around watching metrics after, but this LGTM |
|
@bors r+ |
|
📌 Commit 6c947e3 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 22, 2019
Switch to `conduit-hyper` in place of `civet` `conduit-hyper` now handles normalizing paths, such that `//api/v1` becomes `/api/v1` and doesn't break our router.
|
☀️ Test successful - checks-travis |
bors
added a commit
that referenced
this pull request
Feb 23, 2019
Revert "Auto merge of #1618 - jtgeibel:conduit-hyper-round2, r=sgrif" This reverts commit 69368a6, reversing changes made to 6fa8ad3. When deploying this change, we saw response times nearly triple, and our CPU usage went through the roof. Additionally, this did not appear to fix the memory issues we were hoping to address by removing civet. /cc @jtgeibel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conduit-hypernow handles normalizing paths, such that//api/v1becomes
/api/v1and doesn't break our router.