Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke_test: Set git username and email before committing #9406

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 6, 2024

On GitHub Actions the smoke test currently fails with:

Author identity unknown
*** Please tell me who you are.
Run
  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.

This change adds the necessary git commands to our setup to hopefully make the git commit call succeed now.

Related:

On GitHub Actions the smoke test currently fails with:

```
Author identity unknown
*** Please tell me who you are.
Run
  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
```

This change adds the necessary git commands to our setup to hopefully make the `git commit` call succeed now.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 6, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) September 6, 2024 09:52
@Turbo87 Turbo87 merged commit 0804216 into rust-lang:main Sep 6, 2024
8 checks passed
@Turbo87 Turbo87 deleted the smoky branch September 6, 2024 10:00
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (5bc5796) to head (70223cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/crates_io_smoke_test/src/git.rs 0.00% 18 Missing ⚠️
crates/crates_io_smoke_test/src/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9406      +/-   ##
==========================================
- Coverage   89.14%   89.06%   -0.08%     
==========================================
  Files         285      285              
  Lines       28914    28938      +24     
==========================================
  Hits        25774    25774              
- Misses       3140     3164      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant