Skip to content

Commit

Permalink
add comment about S3 ordering for build logs
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed Feb 29, 2024
1 parent 677297a commit e486388
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/web/build_details.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ pub(crate) async fn build_details_handler(
(
String::from_utf8(file.0.content).context("non utf8")?,
storage
.list_prefix(&prefix)
.list_prefix(&prefix) // the result from S3 is ordered by key
.await
.map_ok(|path| {
path.strip_prefix(&prefix)
Expand Down

1 comment on commit e486388

@Moremoreno
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240229-203517_WhatsApp

Please sign in to comment.