Make crate menu onclick rather than onhover. #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes for a more consistent experience on mobile and desktop. It also, in my opinion, makes for better usability. It's always clear how to close a menu - the same way as you opened it, by clicking. It means that menus aren't opened by stray mouse movements. There are more details on the usability of hover menus at https://uxmovement.com/navigation/why-hover-menus-do-users-more-harm-than-good/.
|
r? @GuillaumeGomez, but I think I like this better. |
jyn514
reviewed
Oct 8, 2020
|
Looks good to me as well! |
|
This has a slight bug: when you hit space to close the menu (navigating with keyboard instead of mouse) it will scroll down the page, not just close the menu. Do you know how to fix that? |
|
Actually, this is a pre-existing bug, no need to fix it here. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes for a more consistent experience on mobile and desktop.
It also, in my opinion, makes for better usability. It's always clear
how to close a menu - the same way as you opened it, by clicking. It
means that menus aren't opened by stray mouse movements. There are more
details on the usability of hover menus at
https://uxmovement.com/navigation/why-hover-menus-do-users-more-harm-than-good/.
Followup from #1077. I realize we hadn't concluded that changing to onclick
was the desired outcome, so consider this a speculative PR to demonstrate
the concept and see how it feels.