Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crates.js and woff2 fonts to required files #1301

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Mar 5, 2021

Attempt at #1300. Untested, but guessing based on #894 and #1109.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding FireSans-Medium.woff2 and FireSans-Regular.woff2 while you're at it? They'd go under ESSENTIAL_FILES_UNVERSIONED.

@dtolnay
Copy link
Member Author

dtolnay commented Mar 5, 2021

Done!

@jyn514 jyn514 added the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 5, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 5, 2021

Thanks!

@dtolnay dtolnay changed the title Add crates.js to required files Add crates.js and woff2 fonts to required files Mar 5, 2021
@jyn514 jyn514 merged commit da1f362 into rust-lang:master Mar 5, 2021
@dtolnay dtolnay deleted the crates.js branch March 5, 2021 05:01
@jsha
Copy link
Contributor

jsha commented Mar 5, 2021

This looks correct to me. Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants