Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rustdoc caching tests #1824

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix rustdoc caching tests #1824

merged 1 commit into from
Sep 8, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Sep 7, 2022

After #1569 the tests failed, first because of 2db2d76, then because of something else.

I don't know why this is breaking, didn't have more time to dig this evening, but this fixes the test.

cc @jsha

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 7, 2022
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the breakage! This change looks good, though I am similarly unsure why they would cause a test to pass where it didn't before.

@Nemo157
Copy link
Member

Nemo157 commented Sep 7, 2022

I did a little more investigation. Previously the test was passing after 5 seconds because iron would timeout the connection for the first response body and allow the second response to go through. In #1814 I added a 2 second timeout on the client-side to avoid 90s long test failures when idle connections exhaust the server, but that meant the client gave up on the second request before the server would timeout the first request and start processing it.

This must just be the only test that attempts to do two requests without either reading the body or dropping the first request (adding a resp.text().unwrap() in between the tests similarly fixes it since reqwest will then close the connection after reading the body).

@syphar syphar merged commit 4d78e03 into rust-lang:master Sep 8, 2022
@syphar syphar deleted the fix-tests branch September 8, 2022 04:46
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 8, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants