migrate CDN & build_queue to SQLx #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
async-build-queue-try-less
branch
from
9833e27
to
9ac8df4
Compare
|
|
syphar
force-pushed
the
async-build-queue-try-less
branch
from
777fa2c
to
132a352
Compare
syphar
force-pushed
the
async-build-queue-try-less
branch
from
132a352
to
0b02b5a
Compare
syphar
force-pushed
the
async-build-queue-try-less
branch
2 times, most recently
from
e4a8244
to
5f32689
Compare
syphar
force-pushed
the
async-build-queue-try-less
branch
from
fc63d41
to
528389a
Compare
|
@GuillaumeGomez I think this is ready for a review now, generally one of the big sqlx refactors again, it's much code, but the pattern is similar. After this I believe it's not much left with old postgres. |
GuillaumeGomez
approved these changes
Sep 23, 2024
|
Code looks good to me (took me a while to get through it ^^'). |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next block of migrations.
I intentionally kept the
BuilldQueuemethods sync soprocess_next_crateworks seamlessly for now.Apart from some small usages in the tests, the consistency check, this is the last piece of the sqlx migration. ( the PR for the rest is ready too).
I still don't like the amount of
block_onin the tests, but that's a topic for more refactorings.