Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log output for coverage command, fix span attributes for builder.build_package #2585

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Aug 13, 2024

  • the build_package span didn't contain the crate name, because the parameter name conflicted with the span name. ( IMO this should error somehow instead of silently duplicating the JSON dict entry )
  • the coverage command didn't log outputs, so we currently can't debug problems with it, like the exit code 101 we are currently seeing

@syphar syphar requested a review from a team as a code owner August 13, 2024 05:50
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 13, 2024
@syphar syphar merged commit a6155e2 into rust-lang:master Aug 13, 2024
11 checks passed
@syphar syphar deleted the fix-span branch August 13, 2024 06:50
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 13, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants