Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set documentation_url to None when url starts with https://docs.rs #2657

Merged

Conversation

zahidkizmaz
Copy link
Contributor

@zahidkizmaz zahidkizmaz commented Oct 26, 2024

Description

Issue: #2184

Documentation URL is mainly used for the external documentation websites. When the url starts with https://docs.rs we don't need to include it on the page.

How to test

With branch checked out run:

cargo run -- build crate diesel 0.13.0
cargo run -- build crate diesel 2.2.4

@zahidkizmaz zahidkizmaz requested a review from a team as a code owner October 26, 2024 22:32
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 26, 2024
src/web/crate_details.rs Outdated Show resolved Hide resolved
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small change needed, thanks!



Documentation url is mainly used for the external documentation
websites. When the url starts with https://docs.rs we don't need to
include it on the page.
@zahidkizmaz zahidkizmaz force-pushed the feat/2184/hide-doc-url-when-it-is-docs-rs branch from 9c4175b to d69c136 Compare October 28, 2024 21:18
@syphar syphar merged commit 05b70cf into rust-lang:master Oct 29, 2024
12 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 29, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants