Only build one target by default #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 21, 2019
|
So, I think having a separate PR to avoiding building the default target twice is better: we should announce breaking changes on the main blog, and doing so is a big ask from a marketing angle. In late February or March I plan to make another breaking change, so we could bundle them together. The separate PR removing the double build for the default target would help mitigating the build cost without visibly affecting users, while we could defer deploying this until next year. |
This was referenced Jan 9, 2020
Closed
jyn514
force-pushed
the
no-more-targets
branch
from
487d3e0 to
2b8a99a
Compare
7 tasks
jyn514
added a commit
to jyn514/winapi-rs
that referenced
this pull request
May 27, 2020
This makes sure that all Windows platforms will have documentation on docs.rs even after docs.rs stops building all tier 1 targets by default. See rust-lang/docs.rs#532 and rust-lang/docs.rs#343 for more context. Additionally, this stops building targets on Mac and Linux since those targets are just empty anyway.
|
Drafted a blog post, feedback is welcome: rust-lang/blog.rust-lang.org#603, |
jyn514
added
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343.
Most of the following comments are related to #550 and can be safely ignored.