Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert style changes to search bar #610

Merged
merged 2 commits into from
Feb 15, 2020
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Feb 15, 2020

Since the changes to search have caused a number of issues (#595, images no longer showing up), I think it makes sense to revert and think about a better solution.

Let me know if I missed any commit, I made this by hitting the 'revert' button on #587 and then on top of that running git revert on the only commit in #577.

r? @GuillaumeGomez

cc @Zexbe

@GuillaumeGomez
Copy link
Member

So the problem was the CSS... I see. I'll make a more precise one if that can help but meanwhile we can merge this so the issue is temporarily fixed. Thanks for investigating @jyn514 !

@GuillaumeGomez GuillaumeGomez merged commit 02f911b into master Feb 15, 2020
@GuillaumeGomez GuillaumeGomez deleted the revert-587-master branch February 15, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants