Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove latest_version_id in favor of a database index #892

Closed
wants to merge 1 commit into from
Closed

[WIP] Remove latest_version_id in favor of a database index #892

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 16, 2020

This is missing the part where I replace it with a database index. Making a PR anyway so I don't forget.

@jyn514
[BROKEN] start on removing latest_version_id
cf2bab6 
This should be an index instead
@jyn514 jyn514 added P-low Low priority issues S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users labels Jul 16, 2020
@syphar
Copy link
Member

syphar commented Nov 13, 2021

@jyn514 I actually think having this denormalized is better (-> #1546 ), especially when the _ which is the latest release_ logic becomes correct for #708

@jyn514 jyn514 closed this Nov 13, 2021
@jyn514 jyn514 deleted the deduplicate branch November 13, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-low Low priority issues S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @syphar