Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All links broken on https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html #138

Closed
brson opened this issue Jan 23, 2019 · 11 comments
Closed

All links broken on https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html #138

brson opened this issue Jan 23, 2019 · 11 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 23, 2019

Every link here takes me to 404 - it creates URLS containing incorrect "rust-2018/rust-2018" paths.

This looks pretty bad and it's hopefully an easy fix.
@steveklabnik
Copy link
Member

steveklabnik commented Jan 23, 2019 via email

@brson
Copy link
Contributor Author

brson commented Jan 23, 2019

Aha. Thanks @steveklabnik.

I don't see how to get to it from https://doc.rust-lang.org/ though.

@brson
Copy link
Contributor Author

brson commented Jan 23, 2019 •
edited
Loading

In addition to ceasing publication on github.io the description of the repo needs to change and the README. They both contain the github.io link.

@brson
Copy link
Contributor Author

brson commented Jan 23, 2019 •
edited
Loading

github.io probably needs a redirect too. Yeah, the first search hit I get is for the github.io version.

@sdht0
Copy link

sdht0 commented Jan 29, 2019

They are also not the same versions. Eg. https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html does not exist on the stable version.

cc #76

@dwijnand
Copy link
Member

How and when is this guide published to https://doc.rust-lang.org/ ?

@dwijnand dwijnand mentioned this issue Jan 29, 2019
Closed
@steveklabnik
Copy link
Member

@dwijnand every rust release, we update the submodule, and so it should be updated like any other docs; changes from here will take between 7 and 13 weeks to make it to the main doc.rust-lang.org page.

@dwijnand
Copy link
Member

I realise your time is limited, but wouldn't it be better if https://doc.rust-lang.org/edition-guide/ were a redirect to (or proxy of) https://rust-lang-nursery.github.io/edition-guide/, with the latest and greatest fixes that have landed? The offline rust distributions will have some slightly older/stale version and, if need be, https://doc.rust-lang.org/stable/edition-guide can host that version of the guide, no?

@steveklabnik
Copy link
Member

steveklabnik commented Jan 29, 2019 via email

@steveklabnik
Copy link
Member

steveklabnik commented Jan 29, 2019 via email

@h-michael h-michael mentioned this issue Feb 5, 2019
Closed
ehuss added a commit to ehuss/edition-guide that referenced this issue Feb 28, 2019
@ehuss
Redirect gh-pages to doc.rust-lang.org.
4a84e74 
This redirects to the nightly copy with the intent that people were coming here
for the up-to-date version. This includes fragment-preserving redirects.

cc rust-lang#76, rust-lang#138
@ehuss ehuss mentioned this issue Feb 28, 2019
Merged
@ehuss
Copy link
Contributor

ehuss commented Feb 28, 2019

Links are now fixed as of #152, and a redirect has been established with #150. The doc.rust-lang.org website should update once rust-lang/rust#58800 is merged and a new nightly is published.

@ehuss ehuss closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @ehuss @brson @dwijnand @sdht0