make libc optional #291
Closed
make libc optional #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
|
I'm not sure when/if you want to bump the minimum supported rust version to 1.60, but with 1.60 stable now, it is possible to merge this if you want. |
|
@Craig-Macomber #303 should make this easier, and avoid the need for the |
|
@Craig-Macomber I've now pushed a change that eliminates the use of libc entirely; with miniz-sys support gone, we no longer need it at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new namespaced-features cargo feature to make libc optional, and not included by default without breaking users of the miniz-sys feature.
This currently requires cargo nightly with
-Z namespaced-features, and should be in stable in the 1.60 release, scheduled for 2022-04-07. Sometime after that, this should be safe to merge.This PR replaces #290 which did the same thing, but as a breaking change.
This fixes #274