Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all stable features on the playground #1970

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Nov 10, 2019

Prompted by this u.rl.o thread, based on docs in the playground source.

@Nemo157
Copy link
Member Author

Nemo157 commented Nov 10, 2019

I assume that the playground builds all crates together in a single build so activating the features from the facade will affect all other crates and there's no point in marking them individually.

futures/Cargo.toml Outdated Show resolved Hide resolved
@taiki-e
Copy link
Member

taiki-e commented Nov 11, 2019

also, some features depend on unstable features and require nightly rustc, so I think it is good to enable only stabilized features instead of enable all-features.

@Nemo157 Nemo157 changed the title Enable all features on the playground Enable all stable features on the playground Nov 11, 2019
@Nemo157
Copy link
Member Author

Nemo157 commented Nov 11, 2019

@taiki-e thanks, that's a good point. I've listed out just the stable features instead.

futures/Cargo.toml Outdated Show resolved Hide resolved
@Nemo157 Nemo157 force-pushed the playground-all-features branch from 7d5475f to e3c7cb0 Compare November 11, 2019 18:08
@cramertj cramertj merged commit 5b0c65c into rust-lang:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants