futures: enable testing without --features thread-pool #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As is, running `cargo test` in the futures root directory fails, as some of the tests are dependent on this functionality. src/lib.rs: The doc tests are a little hairy in src/lib.rs due to default warnings about unused import, combined with warnings being deny()'d tests/eventual.rs: This whole test suite needs this functionality so the test suite is turned into "no code to see here" without this feature. tests/mutex.rs: Only one test relies on this feature, but a lot of cfg() modifiers are employed to keep warnings about unused imports to a minimum.
|
I may take a second pass at this approach and overhaul tests/ one test at a time to make sure they work under all --feature combinations.
|
|
The tests/ aspect of this is now superseded by #2101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, running
cargo testin the futures root directoryfails, as some of the tests are dependent on this functionality.
src/lib.rs: The doc tests are a little hairy insrc/lib.rsdue todefault warnings about unused import, combined with warnings
being
deny()'dtests/eventual.rs: This whole test suite needs this functionalityso the test suite is turned into "no code to see here" without this
feature.
tests/mutex.rs: Only one test relies on this feature, but a lotof
cfg()modifiers are employed to keep warnings about unused importsto a minimum.