Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong/weak pointer counts to Shared #2346

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Add strong/weak pointer counts to Shared #2346

merged 2 commits into from
Feb 14, 2021

Conversation

hlb8122
Copy link
Contributor

@hlb8122 hlb8122 commented Feb 14, 2021

Closes #2330

@hlb8122 hlb8122 changed the title Add strong/weak pointer counts to Shared and WeakShared Futures Add strong/weak pointer counts to Shared and WeakShared Feb 14, 2021
@hlb8122
Copy link
Contributor Author

hlb8122 commented Feb 14, 2021

CI failing on 1.37.0 and 1.39.0 due use of unstable library feature 'weak_counts'. Any advice on how I should proceed?

@taiki-e
Copy link
Member

taiki-e commented Feb 14, 2021

CI failing on 1.37.0 and 1.39.0 due use of unstable library feature 'weak_counts'. Any advice on how I should proceed?

I would prefer to add these methods only to Shared for now. (but, if someone really needs WeakShared::*count, I'm okay with adding it using a build script.)

@hlb8122
Copy link
Contributor Author

hlb8122 commented Feb 14, 2021

I personally have no use for WeakShared::*_count, I added them to anticipate a request for them. Removing them for now.

taiki-e
taiki-e approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e changed the title Add strong/weak pointer counts to Shared and WeakShared Add strong/weak pointer counts to Shared Feb 14, 2021
@taiki-e taiki-e merged commit 4959ecc into rust-lang:master Feb 14, 2021
@taiki-e taiki-e added the A-future Area: futures::future label Feb 20, 2021
@taiki-e taiki-e mentioned this pull request Feb 20, 2021
Merged
@hlb8122 hlb8122 deleted the expose-shared-count branch February 27, 2021 15:55
This was referenced Mar 12, 2021
Closed
Closed
Closed
exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
@hlbarber
Add strong/weak pointer counts to Shared (rust-lang#2346)
e74dcf4 
Co-authored-by: Harry Barber <harry.barber@disneystreaming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-future Area: futures::future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose strong/weak count for Shared
2 participants
@hlb8122 @taiki-e