Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 backports #2419

Merged
merged 12 commits into from
May 7, 2021
Merged

0.3 backports #2419

merged 12 commits into from
May 7, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 7, 2021

Backports:

taiki-e and others added 8 commits May 7, 2021 22:23
Prior to this diff, the Debug impl for oneshot channels printed something like:
```
Sender { inner: Inner { complete: false, data: Lock { locked: false, data: UnsafeCell }, rx_task: Lock { locked: false, data: UnsafeCell }, tx_task: Lock { locked: false, data: UnsafeCell } } }
```
which isn't very helpful. Instead, just print
`Sender { complete: false }` (or `true`, if the other end has dropped).

Note that the `T: Debug` bound is retained to allow for the possibility
of allowing slightly more interesting debug output in the future.
@taiki-e taiki-e added the futures-0.3 Issue related to the 0.3 versions of futures label May 7, 2021
@taiki-e taiki-e merged commit 9779572 into 0.3 May 7, 2021
@taiki-e taiki-e deleted the 0.3-backports branch May 7, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
futures-0.3 Issue related to the 0.3 versions of futures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants