Merge pull request #55 from zedar/extend_compatible_types

Make is_same_type_as() supporting floating point types. Improve type coparison.
rust-lang · Apr 29, 2024 · ac1853f · ac1853f
2 parents 8620316 + 8535da8
commit ac1853f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h
@@ -634,8 +634,7 @@ class type : public memento
 
   virtual bool is_same_type_as (type *other)
   {
-    if (is_int ()
-		 && other->is_int ()
+    if ((is_int () && other->is_int () || is_float() && other->is_float())
 		 && get_size () == other->get_size ()
 		 && is_signed () == other->is_signed ())
     {

diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc
@@ -2331,7 +2331,7 @@ gcc_jit_context_new_comparison (gcc_jit_context *ctxt,
   RETURN_NULL_IF_FAIL (a, ctxt, loc, "NULL a");
   RETURN_NULL_IF_FAIL (b, ctxt, loc, "NULL b");
   RETURN_NULL_IF_FAIL_PRINTF4 (
-    a->get_type ()->unqualified () == b->get_type ()->unqualified (),
+    compatible_types(a->get_type()->unqualified(), b->get_type()->unqualified()),
     ctxt, loc,
     "mismatching types for comparison:"
     " a: %s (type: %s) b: %s (type: %s)",