Add support for custom git extensions #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow one to use git worktrees together with sparse-checkout. Reference: libgit2/libgit2#6031
knutwalker
added a commit
to knutwalker/starship
that referenced
this pull request
Jan 21, 2022
Allows the use of git worktrees together with sparse-checkout. In order for git2 to open such repositories, we need to tell it that we support the worktreeConfig extension. Fixes starship#3245 This commit requires rust-lang/git2-rs#791
5 tasks
|
Seems reasonable to me! For the tests though since this modifies global state I think it'd be good to have a separate test executable in |
|
Thanks for the hint! I have moved the tests to the tests/ folder and rewritten them a bit. They now look like what I initially wanted them to look like, much better :) |
knutwalker
added a commit
to knutwalker/starship
that referenced
this pull request
Mar 30, 2022
Allows the use of git worktrees together with sparse-checkout. In order for git2 to open such repositories, we need to tell it that we support the worktreeConfig extension. Fixes starship#3245 This commit requires rust-lang/git2-rs#791
chipbuster
pushed a commit
to knutwalker/starship
that referenced
this pull request
May 2, 2022
Allows the use of git worktrees together with sparse-checkout. In order for git2 to open such repositories, we need to tell it that we support the worktreeConfig extension. Fixes starship#3245 This commit requires rust-lang/git2-rs#791
jpgrayson
pushed a commit
to stacked-git/stgit
that referenced
this pull request
Sep 10, 2022
Since 0.13, a few changes have been made to git2, including rust-lang/git2-rs#791 which should address the extensions.worktreeConfig issue in #195. The upgrade required fixing uses of [ConfigEntries][1] because it's no longer an iterator. [1]: https://docs.rs/git2/0.15.0/git2/struct.ConfigEntries.html However, it provides an API that lends itself well to `while let` to provide a for loop like experience, so this was an easy fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow one to use git worktrees together with sparse-checkout.
Reference: libgit2/libgit2#6031