-
Notifications
You must be signed in to change notification settings - Fork 63
Allow user to specify ICEs to run + add two new ones #1415
Conversation
Some of the ICEs take an extraordinary amount of time to run on my machine. So I just added the ability to optionally filter down to one or more specific ICEs.
Nice thanks, will take a look in a moment Do you know which ones were taking ages on your machine? We try not to have ones that take an inordinate amount of time |
Are they related to save analysis? rust-lang/rust#101505 |
I don't know how to tell which ones were taking long. They only show up as |
Hmm, on my machine a |
I'm running on an M1 Pro macbook if that makes any difference 🤷 I'll stick some debug logs in there to figure out which ones are running slow |
README.md
Outdated
4. Copy the code that causes the ICE into your new file. | ||
5. (optional) Verify it works by running `rustup update nightly`, then `cargo run` to run the tests. | ||
5. (optional) Verify it works by running `rustup update nightly`, then | ||
`cargo run NUMBER` to run your ICE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the below is clearer:
`cargo run NUMBER` to run your ICE. | |
`cargo run $ISSUE_NUMBER` to run your ICE. |
LGTM! I think we can merge once the comment above is resolved and 09ccc5c is dropped. |
This reverts commit 09ccc5c.
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Was just going to add the two new ICEs, but some of the existing ICEs take an extraordinary amount of time to run on my machine.
So I just added the ability to optionally filter down to one or more specific ICEs when doing
cargo run
.cc rust-lang/rust#101696 for the two new ICEs