Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add some ICEs #1525

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Add some ICEs #1525

merged 3 commits into from
Mar 12, 2023

Conversation

ritikmishra
Copy link
Contributor

@ritikmishra ritikmishra commented Mar 12, 2023 •
edited by JohnTitor
Loading

@JohnTitor
Copy link
Member

rust-lang/rust#108339 doesn't seem like an ICE issue.

@ritikmishra
Copy link
Contributor Author

my bad - it was supposed to be rust-lang/rust#108399

JohnTitor
JohnTitor reviewed Mar 12, 2023
View reviewed changes
ices/106238.rs Outdated Show resolved Hide resolved
ices/107409.rs Outdated Show resolved Hide resolved
ices/108399.rs Show resolved Hide resolved
ices/109020.rs Outdated Show resolved Hide resolved
@JohnTitor
Apply suggestions from code review
d1dbccf
@JohnTitor
Remove non-ICE file
fd8f74e 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
JohnTitor
JohnTitor approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Overall LGTM, fixed style and removed one non-ICE issue.

Some tips for next time:

  • Format code with rustfmt and add the main function if possible; this work is helpful when we move code to rust-lang/rust's regression tests.
  • Check if the issue is already resolved, this can be checked by cargo run

@JohnTitor JohnTitor merged commit 7523a33 into rust-lang:master Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritikmishra @JohnTitor