Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Add new reviewer to librustdoc static files #367

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented Dec 7, 2021

Ping @Folyd if some changes occurred in librustdoc's HTML/CSS/JS.

Related context: rust-lang/rust#91062 (comment)

Ping @Folyd if some changes occurred in librustdoc's HTML/CSS/JS.

Related context: rust-lang/rust#91062 (comment)
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Simulacrum could you merge this please?

@Mark-Simulacrum
Copy link
Member

I am not sure we want to add external folks to the ping lists here -- it implies a level of officialness, and for example the target tier policy talks about not pinging and such for relatively similar reasons.

So my initial inclination is to suggest that this is likely not quite the right path to doing this, even though it looks like a trivial change. It might be useful to have a discussion amongst the rustdoc team as to whether this is the expected way of dealing with changes here -- I recall that other parts of rustdoc, like the JSON API crate, are explicitly versioned (which may imply an opportunity for changelogs / blog posts / something on bumps).

@jyn514
Copy link
Member

jyn514 commented Jan 4, 2022

I really don't want any part of the CSS to be a stable API. The alternative to this is for @Folyd to keep only finding breaking changes after they occur; I think it's reasonable to ping them ahead of time without implying that the PR needs to change. My understanding is that the target policy is saying team members shouldn't be pinged for breakage to tier 3 targets; I don't think it's unreasonable for the target maintainers to be pinged.

@Mark-Simulacrum
Copy link
Member

I'm okay adding this since we're already putting in the comments (i.e., it's not a new comment that gets generated), so the added noise is minimal, but I think we may want to reconsider if the list grows.

@Mark-Simulacrum Mark-Simulacrum merged commit f5ba978 into rust-lang:master Jan 4, 2022
@Folyd Folyd deleted the patch-1 branch January 5, 2022 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants