Implement squash command #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
requested changes
Nov 30, 2020
There was a problem hiding this comment.
Hmm, I tried running this locally on my test repo and this exception happened at startup:
Traceback (most recent call last):
File "/home/pietro/r/github/rust-lang/homu/homu/server.py", line 915, in sync_repo
g.my_username, g.repo_labels)
File "/home/pietro/r/github/rust-lang/homu/homu/main.py", line 1646, in synchronize
command_src=comment.to_json()['html_url'],
File "/home/pietro/r/github/rust-lang/homu/homu/main.py", line 798, in parse_commands
state.save()
File "/home/pietro/r/github/rust-lang/homu/homu/main.py", line 366, in save
self.squash,
AttributeError: 'PullReqState' object has no attribute 'squash'
|
Should be fixed now |
pietroalbini
approved these changes
Dec 1, 2020
|
Can we have a follow up PR expanding the docs (not sure where in repo, available at https://bors.rust-lang.org/ though) to include this? |
|
I think the docs are in the html templates of this repo. |
|
I sent a PR for the docs (#126) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows asking bors to squash all commits before merging.