try builds: include a copyable version of the full commit SHA in comment

[RalfJung]

I regularly trigger try builds to then do a perf run. Perfbot needs the full 40-char SHA1 of the commit. To get that from what bors gives me on a successful try build (like this comment), I need to copy the URL of that link and then remove the junk before the commit.

With this, my hope is I will get a 40-char SHA1 that I can just double-click, Ctrl-C, done. :)
I don't know how to test this change, though.

[Mark-Simulacrum]

This will work conceptually I think -- I should just fix rust-timer to not need that though.

Testing: d0297435b58c0279a1cdb36a5d80ca4ede4ff42a

[bryanburgers]

I agree. I would expect your change to work. I’m not in a position where I can test easily the rest of the week though (4th of July holiday).

LGTM 👍🏼

[RalfJung]

This will work conceptually I think -- I should just fix rust-timer to not need that though.

Even then, a non-link text is easier to copy-paste.

[shepmaster]

or add a link to perfbot? no copy-paste at all

[RalfJung]

What do you mean?

What would be nice is something like@bors try-for-perf or so that automatically triggers perfbot in the "try build successful" message. Bots talking to each other. Skynet is coming :)

[RalfJung]

More automation would be nice, but until then, just landing this would already help.

[Mark-Simulacrum]

Just as a note, perf now supports shorter commit SHAs on input. rust-lang/rustc-perf@140a567

[RalfJung]

@Mark-Simulacrum that's great! I'd have to see how this works in practice; copy-pasting link still requires very careful selection to not also copy surrounding spaces and also not click the link.

So, fine for me to close this until we have further data -- though I also still think this change does make sense.

[Mark-Simulacrum]

I think merging makes sense. We can always revert at a later point if desired.

[RalfJung]

So either this did not work or it did not get deployed or so? rust-lang/rust#64600 (comment) does not contain a copyable commit.

But also it seems we have a new magic command that makes copying unnecessary: @bors try @rust-timer queue

[Mark-Simulacrum]

We may not have re-deployed RCS since then since it usually leads to queue problems (so I'm hesitant to do it for no particular reason); let's go with the new magical command for now.