Autoref/autoderef for operators #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
tesuji
reviewed
Oct 21, 2020
Mark-Simulacrum
force-pushed
the
deautoref-ergo
branch
from
6793963
to
e8059c8
Compare
nikomatsakis
approved these changes
Oct 26, 2020
|
@nikomatsakis Did you intend to mere this or were you waiting on something? |
|
Would a conversation about autoderef behavior in patterns be part of this? |
|
I personally see that as pretty orthogonal. |
Closed
joshtriplett
reviewed
Jun 2, 2021
| - are never quite sufficient (always more references are possible) | ||
| - can cause inference regressions, as the compiler cannot in general know that | ||
| `&T + &T` is equivalent to `u64 + u64`. | ||
|
|
There was a problem hiding this comment.
I think this note accurately captures the primary benefits of this: the compiler could avoid inference failures by considering the reference and non-reference possibilities without them being completely separate impls.
It might be worth mentioning something here about other tradeoffs. And in particular, we should consider whether there are circumstances where we might not want this behavior for a type, and whether people should be able to opt into or out of this behavior for a type.
scottmcm
reviewed
Jun 2, 2021
Mark-Simulacrum
force-pushed
the
deautoref-ergo
branch
from
2128ebc
to
accbd2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extracting from rust-lang/rust#44619, in concert with #62.
r? @rust-lang/lang