Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with rustc build from tarball #1601

Closed
Aaron1011 opened this issue Nov 20, 2019 · 0 comments · Fixed by #1602
Closed

Build fails with rustc build from tarball #1601

Aaron1011 opened this issue Nov 20, 2019 · 0 comments · Fixed by #1602

Comments

@Aaron1011
Copy link
Member

When rustc is built from a tarball, it has no git hash in the output of rustc --version. This causes our build.rs to fail, which expects a git hash and date to always be present in the version string.

See #1536 (comment) for the original discusssion

bors added a commit that referenced this issue Nov 20, 2019
Fix build.rs failing with a rustc built from a tarball

Fixes #1601
bors added a commit that referenced this issue Nov 21, 2019
Fix build.rs failing with a rustc built from a tarball

Fixes #1601
bors added a commit that referenced this issue Nov 21, 2019
Fix build.rs failing with a rustc built from a tarball

Fixes #1601
@bors bors closed this as completed in f10ee11 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant