Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fexecve doesn't exist on mac/ios #732

Closed
Susurrus opened this issue Aug 17, 2017 · 1 comment
Closed

fexecve doesn't exist on mac/ios #732

Susurrus opened this issue Aug 17, 2017 · 1 comment

Comments

@Susurrus
Copy link
Contributor

For some reason it's ignored in build.rs, but my /usr/include/unistd.h on Mac OS X 10.11.6 doesn't have it. It's actually nowhere in /usr/include/. Using this results in a linking error, so I'd suggest it be removed on those platforms even if it's technically a breaking change (as nobody can possibly be using it on those platforms).

I can file a PR to remove it, but what to do about build.rs, anything? Should I change it to be if mac for fexecve to make sure it never creeps back in accidentally?

@alexcrichton
Copy link
Member

Seems fine to me yeah to remove! IIRC these are ignored b/c the exec-family of functions are really hard to verify (the signatures in C are tough for ctest to generate to match)

bors added a commit that referenced this issue Aug 17, 2017
Remove fexecvpe from Haiku and MacOS/IOS where it's not implemented

I was going to remove the skip-check from `build.rs` to see if we might be able to enable the function check on at least some platforms, but I'll assume it doesn't work on any as has been suggested.

Closes #732.
@bors bors closed this as completed in #733 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants