Link to libgcc when statically linking musl #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Could you try bootstrapping rustc with this change to confirm that it works? Once that's working should be good to merge! |
Amanieu
added a commit
to Amanieu/rust
that referenced
this pull request
Jul 8, 2018
This is needed for rust-lang/libc#1034.
|
I bootstrapped rustc with the aarch64-unknown-linux-musl target and it fixes the linker errors in the issues mentioned. There's just a small change required in the CI scripts: rust-lang/rust#52157 |
|
Seems to be a spurious failure on travis? Not sure why this change would cause iOS to fail... |
|
Ok great! In that case let's merge this and fold it with the rust PR @bors: r+ |
|
📌 Commit 920cfea has been approved by |
bors
added a commit
that referenced
this pull request
Jul 9, 2018
Link to libgcc when statically linking musl On some architectures (e.g. aarch64) musl depends on some libgcc functions (`__addtf3`, `__multf3`, `__subtf3`) for `long double` arithmetic that it uses internally. Unfortunately we don't provide these functions in compiler-builtins, so we instead need to get them from libgcc. Fixes: rust-lang/rust#46651 rust-lang/compiler-builtins#201 rust-lang/compiler-builtins#217
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jul 9, 2018
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 10, 2018
Copy libgcc as well after building musl This is needed for rust-lang/libc#1034. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some architectures (e.g. aarch64) musl depends on some libgcc functions (
__addtf3,__multf3,__subtf3) forlong doublearithmetic that it uses internally. Unfortunately we don't provide these functions in compiler-builtins, so we instead need to get them from libgcc.Fixes:
rust-lang/rust#46651
rust-lang/compiler-builtins#201
rust-lang/compiler-builtins#217