Add acct(2) to BSD module

[jabedude]

The acct syscall is supported on BSD platforms, the PR aims to add it to the BSD module.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Thanks! Looks like ci is failing though?

[jabedude]

Looks like it failed here:
/checkout/target/x86_64-rumprun-netbsd/debug/build/libc-test-b256b20c8099faff/out/main.c:5622: undefined reference to acct'

I'm not familiar with the x86_64-rumprun-netbsd triple, but netbsd supports the acct(2) syscall.
Any idea why it fails to build on that platform?

[alexcrichton]

Presumably the API isn't available on that platform? Could it be omitted on that platform?

[jabedude]

Oh definitely! I was just confused why x86_64-rumprun-netbsd didn't compile when netbsd supports acct(2). I will omit with a #[cfg]

[alexcrichton]

Oh the target is a unikernel fork that's super old and hasn't been updated in forever, which may explain that!

[jabedude]

Do you know how to exclude that specific target triple? The Rust documentation doesn't show a way to be more specific than netbsd. See here.

[alexcrichton]

I think that you found the right way to test for it, but it looks like CI is failing?

[jabedude]

I'm sort of at a loss on how to use #[cfg] and keep the linter happy. CI also failed when I used cfg_if!

[alexcrichton]

The current iteration also fails due to using target_vendor on OSX it looks like.

TBH I think we should go back to the original version of this PR and just remove x86_64-rumprun-netbsd from the list of tested targets, AFAIK no one's ever even used the target... Want to go ahead and do that?

[jabedude]

Sounds good. I reverted to the original version

[alexcrichton]

@jabedude to land, can you also remove the rumprun target from .travis.yml?

[alexcrichton]

@bors: r+

[bors]

📌 Commit 70c178d has been approved by alexcrichton

[bors]

⌛ Testing commit 70c178d with merge 0b0cded...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit 70c178d with merge 9c4f6c4...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9c4f6c4 to master...