Manually implement extra traits for mq_attr and sockaddr_nl
#1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pad` or `__reserved` fields are not always 0 on some platforms, so when used in the `PartialEq` implementation being used, fails some comparisons. This commit manually implements the extra traits to correct this behavior.
`nl_pad` field does not contain any actual data, so using it for comparison or hashing doesn't make sense. Instead manually implement extra traits ignoring this field.
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @asomers |
Susurrus
changed the title
mq_attr and sockaddr_nlmq_attr and sockaddr_nl
|
@bors: r+ We should probably just use "special" padding types that derive trivial implementations of the traits (e.g. |
|
📌 Commit 0b34501 has been approved by |
bors
added a commit
that referenced
this pull request
May 27, 2019
Manually implement extra traits for `mq_attr` and `sockaddr_nl` Avoid including padding fields in extra trait implementations as these fields aren't guaranteed to be 0 or some other sensible value. Closes #1302
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 0b34501 has been approved by |
bors
added a commit
that referenced
this pull request
May 27, 2019
Manually implement extra traits for `mq_attr` and `sockaddr_nl` Avoid including padding fields in extra trait implementations as these fields aren't guaranteed to be 0 or some other sensible value. Closes #1302
|
💔 Test failed - checks-travis |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
May 27, 2019
Manually implement extra traits for `mq_attr` and `sockaddr_nl` Avoid including padding fields in extra trait implementations as these fields aren't guaranteed to be 0 or some other sensible value. Closes #1302
|
💔 Test failed - checks-cirrus-freebsd-11 |
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid including padding fields in extra trait implementations as these fields aren't guaranteed to be 0 or some other sensible value.
Closes #1302