-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move musl-compatible constants to linux/mod.rs #1462
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
…will probably fail CI
e4dcbbe
to
903a28b
Compare
I'm a little confused. I rebased onto master but the CI jobs in azure are either not visible in Github or the don't seem to have run even though I didn't disable anything. Is this expected? |
@bors: r+ |
📌 Commit 903a28b has been approved by |
Move musl-compatible constants to linux/mod.rs This is a continuation of #1452. I think CI is ready to run fully and the PR is ready to be merged if the pipelines pass based on the CI I've done using musl libc in my own projects.
It isn't, they aren't currently running for PRs, for some reason (but bors will run them). I need to investigate that. |
@pietroalbini why can that be ? trigger: ["auto-libc","try"]
pr: ["master"] Shouldn't that trigger azure jobs in PR builds ? (e.g. see this other PR where only cirrus-ci is shown: #1461) |
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
This is a continuation of #1452. I think CI is ready to run fully and the PR is ready to be merged if the pipelines pass based on the CI I've done using musl libc in my own projects.