-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort targets in documentation. Fixes #1524. #1556
Conversation
Should be a simple but effective fix for rust-lang#1524. Assume `sort` command is available.
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 5747422 has been approved by |
Thanks, this is exactly what I had in mind. |
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
@gnzlbg I also don't like unsorted random lists. But the list at https://rust-lang.github.io/libc/#platform-specific-documentation seems not quite sorted. Does it take some time till the new documentation get pushed? |
It should just work, but apparently it stopped working 2 months ago: https://github.com/rust-lang/libc/tree/gh-pages (last time that was updated). The job for this is indeed running: https://github.com/rust-lang/libc/blob/master/ci/azure.yml#L132 But apparently the deploy to github pages is being skipped: https://dev.azure.com/rust-lang2/libc/_build/results?buildId=501 @pietroalbini do you have any idea of what might be going on ? |
Ok, so the problem is that these run in the |
I've added a new pipeline that should build master: https://dev.azure.com/rust-lang2/libc/_build?definitionId=7 |
@senden9 thanks, look: https://rust-lang.github.io/libc/#platform-specific-documentation now everything shows up sorted! |
#1557 should fix it |
Good. Found just in that moment the same lines that you edited. |
Should be a simple but effective fix for #1524. Assume
sort
command is available.