Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort targets in documentation. Fixes #1524. #1556

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

senden9
Copy link
Contributor

@senden9 senden9 commented Oct 16, 2019

Should be a simple but effective fix for #1524. Assume sort command is available.

Should be a simple but effective fix for rust-lang#1524. Assume `sort` command is available.
@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 17, 2019

📌 Commit 5747422 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 17, 2019

⌛ Testing commit 5747422 with merge bc5c15e...

bors added a commit that referenced this pull request Oct 17, 2019
Sort targets in documentation. Fixes #1524.

Should be a simple but effective fix for #1524. Assume `sort` command is available.
@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

Thanks, this is exactly what I had in mind.

@bors
Copy link
Contributor

bors commented Oct 17, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing bc5c15e to master...

@bors bors merged commit 5747422 into rust-lang:master Oct 17, 2019
@senden9
Copy link
Contributor Author

senden9 commented Oct 17, 2019

@gnzlbg I also don't like unsorted random lists.

But the list at https://rust-lang.github.io/libc/#platform-specific-documentation seems not quite sorted. Does it take some time till the new documentation get pushed?
Because as far as i understand this list is generated form the master Branch. My PR is now merged into master. So this list should be now sorted or?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

It should just work, but apparently it stopped working 2 months ago: https://github.com/rust-lang/libc/tree/gh-pages (last time that was updated).

The job for this is indeed running: https://github.com/rust-lang/libc/blob/master/ci/azure.yml#L132

But apparently the deploy to github pages is being skipped: https://dev.azure.com/rust-lang2/libc/_build/results?buildId=501

@pietroalbini do you have any idea of what might be going on ?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

But apparently the deploy to github pages is being skipped: https://dev.azure.com/rust-lang2/libc/_build/results?buildId=501

Ok, so the problem is that these run in the auto-libc branch, but the deployment only happens for master. The master branch is never built anymore, so... nothing gets published.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

I've added a new pipeline that should build master: https://dev.azure.com/rust-lang2/libc/_build?definitionId=7

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

@senden9 thanks, look: https://rust-lang.github.io/libc/#platform-specific-documentation now everything shows up sorted!

@senden9
Copy link
Contributor Author

senden9 commented Oct 17, 2019

Nice :D.

I see mipsel-unknown-linux-gnu is two times in the list. See screenshot.
image
Should I fix that in another PR by checking for doubles in the list (dox.sh) or do you want to fix that problem on another level?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

#1557 should fix it

@senden9
Copy link
Contributor Author

senden9 commented Oct 17, 2019

Good. Found just in that moment the same lines that you edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants