-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RISC-V 64-bit GNU/Linux #1606
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a build job for this target here to make sure that this at least compiles: https://github.com/rust-lang/libc/blob/master/ci/build.sh#L224
You might want to consider taking over #1416 as a follow up (no need to try to do any of that here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors: r+
@bors: r+ |
📌 Commit 112b7f9 has been approved by |
The target specification is not in the latest nightly, only master - even when using |
@bors: r+ |
📌 Commit a06978b has been approved by |
Support for RISC-V 64-bit GNU/Linux Add support for RISC-V 64-bit GNU/Linux. Follow up to rust-lang/rust#66661. r? @alexcrichton
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
Add support for RISC-V 64-bit GNU/Linux.
Follow up to rust-lang/rust#66661.
r? @alexcrichton