Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait4 for macOS and FreeBSD #1656

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Conversation

darcyliu
Copy link
Contributor

@darcyliu darcyliu commented Feb 8, 2020

This PR aims to add the system call wait4 which is supported by macOS and FreeBSD.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR here, but right now there's not many maintainers to help merge this, so it may take awhile.

@JohnTitor
Copy link
Member

@darcyliu Could you rebase to check current CI status?
r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned gnzlbg Mar 8, 2020
@darcyliu darcyliu force-pushed the bsd-wait4 branch 2 times, most recently from 166578e to fa79468 Compare March 8, 2020 03:01
@darcyliu
Copy link
Contributor Author

darcyliu commented Mar 8, 2020

Hi @JohnTitor I've updated.

@JohnTitor
Copy link
Member

Looks good! Could you also squash commits into one to make log cleaner?

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 8ba9ba2 into rust-lang:master Mar 8, 2020
@darcyliu darcyliu deleted the bsd-wait4 branch March 8, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants