Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i686-pc-windows-gnu CI #1726

Closed
wants to merge 2 commits into from
Closed

Fix i686-pc-windows-gnu CI #1726

wants to merge 2 commits into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Apr 8, 2020

Fixes #1592

@rust-highfive
Copy link

r? @JohnTitor

(rust_highfive has picked a reviewer for you, use r? to override)

@mati865
Copy link
Contributor Author

mati865 commented Apr 8, 2020

Huh?

bad max_align_t size: rust: 24 (0x18) != c 48 (0x30)
bad max_align_t align: rust: 8 (0x8) != c 16 (0x10)

Seems like MinGW on the CI is seriously old.

@retep998
Copy link
Member

retep998 commented Apr 8, 2020

Why does time on 32-bit mingw take a 64-bit value while time_t is 32-bit?

@mati865
Copy link
Contributor Author

mati865 commented Apr 8, 2020

Why does time on 32-bit mingw take a 64-bit value while time_t is 32-bit?

Because of #[link_name = "_gmtime64_s"], on second thought it's not correct and should be #[link_name = "_gmtime32_s"] for i686.

Anyway it still crashes with GCC so probably that's GCC fault.

@mati865 mati865 closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i686-pc-windows-gnu broken on CI
4 participants
@mati865 @rust-highfive @retep998 @JohnTitor