-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process_vm_readv, process_vm_writev should be available on android #1878
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Closing and reopening to re-run CI. |
@joshtriplett I am not sure why its failing. I used android-ndk's aarch64-linux-android27-clang |
On Fri, Oct 02, 2020 at 07:46:05PM -0700, Rupansh wrote:
@joshtriplett I am not sure why its failing. I used android-ndk's aarch64-linux-android27-clang
Since it succeeds on other Android targets, and fails on aarch64, is it
possible that the Android SDK for aarch64 doesn't have that syscall in
its headers yet?
|
sysroot/usr/include/sys/uio.h has it in my case for android27. It was added in a later version. android21(Lollipop, the TC used by CI) is pretty old now!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure on AArch64 should be related to #1765. Could you skip the test for it like https://github.com/rust-lang/libc/pull/1867/files#diff-aedce4e8d381f53dae77653609e3174da7ee2a184308251ad33f7a47bebabe14R1593-R1608?
Signed-off-by: rupansh-arch <rupanshsekar@hotmail.com>
Thanks! |
📌 Commit 0121c5c has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12 |
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh see rust-lang/libc#1878 Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh see rust-lang/libc#1878 Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh see rust-lang/libc#1878 Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
process_vm_readv and process_vm_writev generally return -EPERM(-1) when used in android, however the syscalls work fine when running under privileged shell.
The following was tested(with modified nix) on Android 9/10 running Linux Kernel 4.9 on a SDM 845 phone:
This will work fine when run under su shell.