unix: Add openpty(3) and forkpty(3) for non-Apple platforms #246
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Can you add the link-to-libutil in the same place that we link to libc? That way we won't double-link it as the standard library will already be linking to it. |
|
Is f0d652f what you meant? I'll squash before merge. |
Evidently not quite; the linkers are not happy. |
|
Or maybe the issue is that CI should somehow not build with stdbuild? |
|
Hm right, we're adding a new library so the libstd libc doesn't link these just yet. I don't believe there's any harm for linking these libraries twice, so yeah I think that we'll need to add link directives in the libc crate itself for them for now. It's ok to not extract out the functions into a separate |
kamalmarhubi
force-pushed
the
openpty
branch
2 times, most recently
from
b5234a4
to
8996e12
Compare
|
Fixed (I think), and squash / rebased. :-) |
unix: Add openpty(3) and forkpty(3) for non-Apple platforms The functions were added for Apple in #202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
|
💔 Test failed - travis |
The functions were added for Apple in rust-lang#202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
|
Missed the link attribute on freebsd. |
|
@bors: r+ |
|
📌 Commit 9c4af10 has been approved by |
unix: Add openpty(3) and forkpty(3) for non-Apple platforms The functions were added for Apple in #202. Adding them to other platforms was pending an amendment to RFC 1291 to expand the scope of libc to include libutil. The amendment was merged as rust-lang/rfcs#1529
|
☀️ Test successful - status-appveyor, travis |
The functions were added for Apple in #202. Adding them to other
platforms was pending an amendment to RFC 1291 to expand the scope of
libc to include libutil. The amendment was merged as
rust-lang/rfcs#1529