Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare clock_settime for macOS. #2496

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Oct 31, 2021

Looking at time.h for macOS 11.5 clock_settime still doesn't seem to be exported for iOS. Declaring it only for macOS (using #2208 as an example of how).

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@DimitrisJim
Copy link
Contributor Author

r? @JohnTitor

Since you added the previous PR

@rust-highfive rust-highfive assigned JohnTitor and unassigned Amanieu Oct 31, 2021
@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2021

📌 Commit 7a27082 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 2, 2021

⌛ Testing commit 7a27082 with merge 26e1d63...

bors added a commit that referenced this pull request Nov 2, 2021
Declare clock_settime for macOS.

Looking at [time.h for macOS 11.5](https://opensource.apple.com/source/Libc/Libc-1439.141.1/include/time.h.auto.html) `clock_settime` still doesn't seem to be exported for iOS. Declaring it only for macOS (using #2208 as an example of how).
@bors
Copy link
Contributor

bors commented Nov 2, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

TImeout, @bors retry

bors added a commit that referenced this pull request Nov 2, 2021
Declare clock_settime for macOS.

Looking at [time.h for macOS 11.5](https://opensource.apple.com/source/Libc/Libc-1439.141.1/include/time.h.auto.html) `clock_settime` still doesn't seem to be exported for iOS. Declaring it only for macOS (using #2208 as an example of how).
@bors
Copy link
Contributor

bors commented Nov 2, 2021

⌛ Testing commit 7a27082 with merge d086559...

@bors
Copy link
Contributor

bors commented Nov 2, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Nov 2, 2021

⌛ Testing commit 7a27082 with merge fa6f26b...

@bors
Copy link
Contributor

bors commented Nov 3, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing fa6f26b to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants