Correct the size of certain types on espidf platform #2708
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
LGTM! Is there a reason why this PR is still a draft? |
|
Apologies! I was double checking the c typedef's are the same in both our xtensa & RISC based toolchains, and forgot to mark this as ready. Should be good to go now :) |
|
@bors r+ |
|
📌 Commit ab62380 has been approved by |
Correct the size of certain types on espidf platform This was initially discovered in esp-rs/rust#92, the reason stat fails on the esp-idf platform is because the `stat` struct has a different layout on the Rust side compared to the C side.
|
💔 Test failed - checks-actions |
|
CI failures seems unrelated? Looks like they're also failing on master. |
|
@bors retry |
Correct the size of certain types on espidf platform This was initially discovered in esp-rs/rust#92, the reason stat fails on the esp-idf platform is because the `stat` struct has a different layout on the Rust side compared to the C side.
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
|
Note that this broke building std on these |
…ark-Simulacrum espidf: fix stat Marking as draft as currently dependant on [a libc fix](rust-lang/libc#2708) and release.
…k-Simulacrum espidf: fix stat Marking as draft as currently dependant on [a libc fix](rust-lang/libc#2708) and release.
espidf: fix stat Marking as draft as currently dependant on [a libc fix](rust-lang/libc#2708) and release.
This was initially discovered in esp-rs/rust#92, the reason stat fails on the esp-idf platform is because the
statstruct has a different layout on the Rust side compared to the C side.