added const SOCK_SEQPACKET, and SOCK_RDM where applicable #300
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
…as well as SCTP IP
added const SOCK_SEQPACKET, and SOCK_RDM where applicable ... which is used for UNIX Seqpacket sockets as well as SCTP IP. I have verified in source on a couple Linux flavours as well as freebsd and darwin source that SOCK_SEQPACKET has value 5. Solaris is the odd one with a value of 6. I also added RDM for solaris (value 5)
|
💔 Test failed - travis |
|
Looks like networking failed in the openbsd test. |
|
it is due to maintenance on ftp5 : https://marc.info/?l=openbsd-misc&m=146427439004957 |
|
@bors: retry |
added const SOCK_SEQPACKET, and SOCK_RDM where applicable ... which is used for UNIX Seqpacket sockets as well as SCTP IP. I have verified in source on a couple Linux flavours as well as freebsd and darwin source that SOCK_SEQPACKET has value 5. Solaris is the odd one with a value of 6. I also added RDM for solaris (value 5)
|
💔 Test failed - status-appveyor |
|
@bors: retry On Fri, May 27, 2016 at 11:18 AM, bors notifications@github.com wrote:
|
added const SOCK_SEQPACKET, and SOCK_RDM where applicable ... which is used for UNIX Seqpacket sockets as well as SCTP IP. I have verified in source on a couple Linux flavours as well as freebsd and darwin source that SOCK_SEQPACKET has value 5. Solaris is the odd one with a value of 6. I also added RDM for solaris (value 5)
|
💔 Test failed - travis |
|
@bors: retry On Fri, May 27, 2016 at 11:53 AM, bors notifications@github.com wrote:
|
added const SOCK_SEQPACKET, and SOCK_RDM where applicable ... which is used for UNIX Seqpacket sockets as well as SCTP IP. I have verified in source on a couple Linux flavours as well as freebsd and darwin source that SOCK_SEQPACKET has value 5. Solaris is the odd one with a value of 6. I also added RDM for solaris (value 5)
|
☀️ Test successful - status-appveyor, travis |
Add support for MIPS targets Closes rust-lang#300
This was historically done as the contents of the `i686` module wouldn't actually compile on i586 for various reasons. I believe I've tracked this down to rust-lang#300 where LLVM refuses to compile a function using the `x86_mmx` type without actually enabling the `mmx` feature (sort of reasonably so!). This commit will now compile in both the `i586` and `i686` modules of this crate into the `i586-unknown-linux-gnu` target, and the relevant functions now also enable the `mmx` feature if they're using the `__m64` type. I believe this is uncovering a more widespread problem where the `__m64` isn't usable outside the context of `mmx`-enabled functions. The i686 and x86_64 targets have this feature enabled by default which is why it's worked there, but they're not enabled for the i586 target. We'll probably want to consider this when stabilizing!
... which is used for UNIX Seqpacket sockets as well as SCTP IP.
I have verified in source on a couple Linux flavours as well as freebsd and darwin source that SOCK_SEQPACKET has value 5.
Solaris is the odd one with a value of 6. I also added RDM for solaris (value 5)