Cast unsigned literals to signed integers. #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This makes it explicity that we know the literals are to large and will result in a negative number. This gets rid of a warning in 1.9.0 and younger versions, as well as an error when using the constants as discrimintants of #[repr(i32)] enumerations in older versions.
|
Thanks! |
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
The public API isn't changing in this commit but the internal organization is being rejiggered. Instead of `x86/$subtarget/$feature.rs` the folders are changed to `coresimd/x86/$feature.rs` and `coresimd/x86_64/$feature.rs`. The `arch::x86_64` then reexports both the contents of the `x86` module and the `x86_64` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it explicity that we know the literals are to large and
will result in a negative number. This gets rid of a warning in
1.9.0 and younger versions, as well as an error when using the
constants as discrimintants of #[repr(i32)] enumerations in older
versions.
For nix-rust/nix#386